Author: kkolinko Date: Tue Oct 12 14:11:06 2010 New Revision: 1021781 URL: http://svn.apache.org/viewvc?rev=1021781&view=rev Log: vote
Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1021781&r1=1021780&r2=1021781&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Oct 12 14:11:06 2010 @@ -236,31 +236,39 @@ PATCHES PROPOSED TO BACKPORT: Add context option to disable URL re-writing and session parsing from URLs Based on a patch by Wesley. https://issues.apache.org/bugzilla/attachment.cgi?id=26135 - +1: markt + +1: markt, kkolinko -1: + kkolinko: minor thoughts, not mandatory: + - I think in CoyoteAdapter.java the added "if (isURLRewritingDisabled(request))" call + should better be moved below setWrapper(..), for better readability. + - Implementation of CoyoteAdapter.isURLRewritingDisabled(request) could call + request.getContext(), because request.setContext(..) was already called, + but I do not insist on such changes. + - Do not remove "// Make sure no session ID is returned" comment. + - Documentation update will be needed. * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49972 Potential thread safety issues in FastHttpDateFormat http://svn.apache.org/viewvc?rev=1005452&view=rev - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49986 Thread safety for JSP reload. http://svn.apache.org/viewvc?rev=1005467&view=rev (timw) - +1: markt, kfujino + +1: markt, kfujino, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987 Thread safety issue with population of servlet context initialization parameters. http://svn.apache.org/viewvc?rev=1005647&view=rev - +1: markt, kfujino + +1: markt, kfujino, kkolinko -1: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50066 Compile recursive tag file if it depends on a JAR. Patch provided by Sylvain Laurent. https://issues.apache.org/bugzilla/attachment.cgi?id=26149 - +1: markt + +1: markt, kkolinko -1: --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org