On 16/11/2010 15:44, Konstantin Kolinko wrote:
> I saw the following fragment in ContainerBase.logName():
> Lines 1277-1278:
>
> } else if (name.startsWith("##")) {
> name = "/" + name;
> }
>
> It was added by
> http://svn.apache.org/viewvc?view=revision&revision=1029527
>
> Shouldn't it be
> name = "/" + name.substring(2);
No. The ## are intended to be part of the logger name. This code just
adds consistency for the ROOT webapp.
> Anyway,
> 1) I am not sure that logging categories should depend on versioning.
> It would be hard to configure logging across different versions of the webapp.
The general principle with the parallel deployment is as far as
possible to treat each version of a web application as a separate web
application. That means separate loggers.
> I do not mind though if version will be a subcategory (a suffix
> separated by a dot).
I think the names should be consistent with the container names - as
they are now. Look at how this is handled for a multi-level context.
> 2) This code is in a loop that iterates over parents of a context. So
> the name can belong to a host or an engine. (Though unlikely anyone
> will name them like that, so actually I do not bother about this).
Agreed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
