On 10.01.2011 19:54, Mark Thomas wrote:
The proposed Apache Tomcat 7.0.6 release is now available for voting.
It can be obtained from:
http://people.apache.org/~markt/dev/tomcat-7/v7.0.6/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_6/
The proposed 7.0.6 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 7.0.6 Alpha
[ ] Beta - go ahead and release as 7.0.6 Beta
[X] Stable - go ahead and release as 7.0.6 Stable
- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- Unit tests run OK except for one failures (see below).
Tests have been run on Solaris 10 Sparc with 2 CPUs
using Java 1.6.0_17.
- few Javadoc warning (see below)
Looks we finally have a TC 7 stable. Good work!
1 unit test failing (not a problem)
-----------------------------------
Testsuite: org.apache.catalina.connector.TestMaxConnections
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 6.869 sec
...
Testcase: testConnector took 6.857 sec
FAILED
The number of successful requests should have been 4-5, actual 6
junit.framework.AssertionFailedError: The number of successful requests
should have been 4-5, actual 6
at
org.apache.catalina.connector.TestMaxConnections.testConnector(TestMaxConnections.java:58)
I instrumented the test client and the servlet a bit and one sees, that
in fact 6 client connects return quickly after each other
(reproducible), but the servlet is only started for the first 4 and only
after those finished does the servlet start for the other two. So it's
very likely, that the accept of "1" leads to Solaris/Java accepting 2
additional connections. I don't have the time right now to check (snoop)
and look at JVM code, but on the short hand it might be OK to just
increase the acceptable limit for the test from 5 to 6, which has still
enough headroom to the tested 10 connections.
Few javadoc warnings (minor)
----------------------------
org/apache/catalina/authenticator/AuthenticatorBase.java:175: warning -
Tag @link: reference not found: java.secure.SecureRandom
org/apache/catalina/authenticator/AuthenticatorBase.java:186: warning -
Tag @link: reference not found: java.secure.SecureRandom
org/apache/catalina/authenticator/AuthenticatorBase.java:196: warning -
Tag @link: reference not found: java.secure.SecureRandom
org/apache/catalina/filters/RequestFilter.java:131: warning - @param
argument "allow" is not a parameter name.
org/apache/catalina/Host.java:153: warning - Tag @link: can't find
appBase in org.apache.catalina.Host
org/apache/catalina/Host.java:161: warning - Tag @link: can't find
appBase in org.apache.catalina.Host
org/apache/catalina/session/ManagerBase.java:114: warning - Tag @link:
reference not found: java.secure.SecureRandom
org/apache/catalina/session/ManagerBase.java:125: warning - Tag @link:
reference not found: java.secure.SecureRandom
org/apache/catalina/session/ManagerBase.java:135: warning - Tag @link:
reference not found: java.secure.SecureRandom
org/apache/catalina/valves/RequestFilterValve.java:144: warning - @param
argument "allow" is not a parameter name.
org/apache/tomcat/util/net/AbstractEndpoint.java:319: warning - Tag
@link: reference not found: ProtocolHandler
org/apache/tomcat/util/net/AbstractEndpoint.java:327: warning - Tag
@link: reference not found: ProtocolHandler
org/apache/tomcat/util/threads/CounterLatch.java:128: warning - @return
tag has no arguments.
org/apache/tomcat/util/threads/CounterLatch.java:157: warning - @return
tag has no arguments.
org/apache/tomcat/util/threads/CounterLatch.java:167: warning - Tag
@see: reference not found: {...@link #releaseAll()}
org/apache/tomcat/util/threads/CounterLatch.java:167: warning - Tag
@see:illegal character: "123" in "{...@link #releaseAll()}"
org/apache/tomcat/util/threads/CounterLatch.java:167: warning - Tag
@see:illegal character: "64" in "{...@link #releaseAll()}"
org/apache/tomcat/util/threads/DedicatedThreadExecutor.java:104: warning
- @return tag has no arguments.
org/apache/tomcat/util/threads/DedicatedThreadExecutor.java:49: warning
- @return tag has no arguments.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
