2011/1/28 Konstantin Kolinko <knst.koli...@gmail.com>: > 2011/1/28 Rainer Jung <rainer.j...@kippdata.de>: >> On 27.01.2011 21:39, Konstantin Kolinko wrote: >>> >>> 2011/1/27 jean-frederic clere<jfcl...@gmail.com>: >>>> >>>> On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: >>>>> >>>>> 2011/1/25 jean-frederic clere<jfcl...@gmail.com>: >>>>>> >>>>>> The candidates binaries are available here: >>>>>> http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ >>>>>> >>>>>> According to the release process, the 6.0.31 build corresponding to the >>>>>> tag TOMCAT_6_0_31 is: >>>>> >>>>>> [x] Beta >>>>> >>>>> That is because of issue observed with Nio connector. >>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 >>>>> >>>>> I am not saying "broken", because other connectors run OK for me. >>>>> Though, as 6.0.31 goal was to resolve regression with Nio it does not >>>>> quite serve that purpose. >>>>> >>>>> The above mentioned issue is present in 6.0.30 as well. >>>> >>>> Ok then we should go for a 6.0.32 once it is solved. >>>> >>> >>> Regarding the status for 6.0.32: >>> >>> 1. The fix for the above mentioned regression has been applied. >>> 2. Of the currently open issues the following one is of concern: >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50631 >>> InternalNioInputBuffer should honor maxHttpHeadSize >>> It affects 6.0 and 7.0. >> >> So if fixing NIO is close, should we really release 6.0.31 shortly after the >> NIO broken 6.0.30 just to release 6.0.32 shortly after? If it doesn't take >> more than say 2-3 weeks to release 6.0.32, I would suggest we skip 6.0.31. >> The reason for 6.0.31 was fixing a NIO regression, so IMHO we shouldn't >> release it if it contains another serious NIO issue already known. >> > > Looking at https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 > once again, I would say that the only consequence of that issue is flooding the logs. It happens when recycling the buffer for the second time. So, the recycle has already successfully happened once.
Thus while 6.0.30 was not usable because of OOM in Nio, 6.0.31 is usable though has an inconvenience. I think that it is better to release 6.0.31 (so that it were available for download). There is some motto "release often". When we can go for 6.0.32/6.0.33? The code itself is stable as it is now. I am not sure of being able to quickly fix BZ 50631 - I have an idea, but I am not sure of consequences - it might destabilize things. Have anyone run TCK? Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
