https://issues.apache.org/bugzilla/show_bug.cgi?id=51408
--- Comment #4 from Konstantin Kolinko <[email protected]> 2011-06-21 23:57:20 UTC --- (In reply to comment #0) > There seem to be rather a lot of instances where Strings and bytes are > cconverted using the default charset. Please be specific! Searching through the TC7 source code I found ===================================== 1) 0 wrong calls to String.getBytes() That is 1. Disregarding the test classes - have not looked through them at all, 2. Disregarding some never called test code in o.a.c.tribes.membership.Constants.main() 3. Disregading legit calls to this method, when encoding is configurable and the default encoding is used as fallback. Nothing to do there. ===================================== 2) 2 places where new String(byte[]) calls might be fixed: 2.1. In SSIFilter#doFilter(), the following line: res.getWriter().write(new String(bytes)); It is some fallback code, when there is no OutputStream available, but only a writer. Is it possible to get encoding of the writer there, e.g. from content-type header? Patches are welcome. It is an odd and rare use case though. 2.2. In JNDIRealm#getAttributeValue(String,Attributes) valueString = new String((byte[]) value); I do not know JNDI API enough to comment here. The rest are fallbacks, debug code etc. ===================================== 3) new String(byte[],int,int): 3.1. WebappClassLoader#findResourceInternal() String str = new String(binaryContent,0,pos); That is the correct code and should stay as is. See r303915. The rest are fallbacks, debug code etc. ===================================== 4) new FileWriter(String) or new FileWriter(String,[boolean]) instead of OutputStreamWriter + FileOutputStream Is used in one place only: 4.1. in AccessLogValve.open() This can be fixed - to add "encoding" configuration option for the valve. I think there was an enhancement request for that. ===================================== That is all. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
