Since OneLineFormatter now uses the DateFormatCache util class, and to prevent any dependency of juli form other packages that util class sits in juli, what do we think about using it also in AccessLogValve?
At the moment the valve has a local copy as an inner class. Of course a dependency on juli is OK, because we have it most of the time for logging, but it is a bit strange, that this time it is for a utility class. What do you think about directly using the juli DateFormatCache in the AccessLogValve? Overall I think the benefits of having the code only once outweigh the strangeness of that kind of dependency. And yes, I removed a small generalization form the class when including it in juli, which I would thean add back to make the same class work for both uses. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
