On 05/07/2011 11:21, Konstantin Kolinko wrote: > 2011/7/5 <ma...@apache.org>: >> Author: markt >> Date: Tue Jul 5 10:03:06 2011 >> New Revision: 1142953 >> >> URL: http://svn.apache.org/viewvc?rev=1142953&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51472 >> Correctly test modifiers when resolving bean methods with the BeanELResolver. >> Patch provided by Friedhelm Kuehn. >> >> Modified: >> tomcat/trunk/java/javax/el/BeanELResolver.java >> tomcat/trunk/webapps/docs/changelog.xml > > > >> private static final Method getMethod(Class<?> type, Method m) { >> - if (m == null || Modifier.isPublic(type.getModifiers())) { >> + if (m == null || Modifier.isPublic(m.getModifiers())) { > > I think the old code is the correct one.
I think you're right. > See that below that in BeanELResolver.getMethod() we call > Class..getMethod(...) which returns only public methods. I was looking at the calls to desciptor.get[Read|Write]Method and didn't follow the code far enough to find the limit to just public methods. I'll revert the patch. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
