https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #19 from Christopher Schultz <ch...@christopherschultz.net>
2011-07-05 22:54:15 UTC ---
Thanks for the comments. Very helpful!
(In reply to comment #18)
> (In reply to comment #16)
>
> Regarding attachment 27225 [details] (Java patch) I have two comments:
>
> 1) Code formatting.
> We usually have "{" on the same line as previous statement (like in Java
> coding
> style).
I'm happy to change the use of whitespace, but "usually" is somewhat subjective
in the TC code base :)
> 2) I go not get why there are two methods in SSL.java:
> fipsModeSet(Integer mode) and fipsModeSet(int mode).
>
> If you need class object of "int" to do lookup of the method, it is available
> as Integer.TYPE.
I mostly reduced the patch provided by (the other) Chris and I remember
thinking about the overloaded methods but can't remember why I decided to leave
them there. Certainly the rest of the code does not require both methods.
Come to think of it, I'm not sure why the method call needs to be done using
reflection at all... both AprLifecycleListener.java and SSL.java are in the
Tomcat project (as opposed to tcnative) and thus should never be out of sync.
The only potential problem is if the native call fails because of a mismatched
tcnative library, but that would fail in a way that reflection wouldn't solve,
anyway.
I'll update the patch.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
