Author: rjung
Date: Mon Jul 11 22:30:45 2011
New Revision: 1145387
URL: http://svn.apache.org/viewvc?rev=1145387&view=rev
Log:
Never compare docs and code:
- enableLookups for connector was
"false" by default at least the last 5 years.
- resolveHosts for normal and extended
access log valve wasn't functional in
the last 4 years (see e.g. r494191) and
IMHO since noone complaint switching
enableLookups to "true" instead is an
appropriate alternative. So document
that "resolveHosts" is no longer supported.
Modified:
tomcat/trunk/webapps/docs/config/ajp.xml
tomcat/trunk/webapps/docs/config/http.xml
tomcat/trunk/webapps/docs/config/valve.xml
tomcat/trunk/webapps/docs/funcspecs/fs-admin-objects.xml
Modified: tomcat/trunk/webapps/docs/config/ajp.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?rev=1145387&r1=1145386&r2=1145387&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/ajp.xml (original)
+++ tomcat/trunk/webapps/docs/config/ajp.xml Mon Jul 11 22:30:45 2011
@@ -92,7 +92,7 @@
order to return the actual host name of the remote client. Set
to <code>false</code> to skip the DNS lookup and return the IP
address in String form instead (thereby improving performance).
- By default, DNS lookups are enabled.</p>
+ By default, DNS lookups are disabled.</p>
</attribute>
<attribute name="maxPostSize" required="false">
Modified: tomcat/trunk/webapps/docs/config/http.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1145387&r1=1145386&r2=1145387&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/trunk/webapps/docs/config/http.xml Mon Jul 11 22:30:45 2011
@@ -90,7 +90,7 @@
order to return the actual host name of the remote client. Set
to <code>false</code> to skip the DNS lookup and return the IP
address in String form instead (thereby improving performance).
- By default, DNS lookups are enabled.</p>
+ By default, DNS lookups are disabled.</p>
</attribute>
<attribute name="maxPostSize" required="false">
Modified: tomcat/trunk/webapps/docs/config/valve.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=1145387&r1=1145386&r2=1145387&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/valve.xml (original)
+++ tomcat/trunk/webapps/docs/config/valve.xml Mon Jul 11 22:30:45 2011
@@ -148,10 +148,8 @@
</attribute>
<attribute name="resolveHosts" required="false">
- <p>Set to <code>true</code> to convert the IP address of the remote
- host into the corresponding host name via a DNS lookup. Set to
- <code>false</code> to skip this lookup, and report the remote IP
- address instead.</p>
+ <p>This attribute is no longer supported. Use the connector
+ attribute <code>enableLookups</code> instead.</p>
</attribute>
<attribute name="suffix" required="false">
@@ -209,7 +207,7 @@
<li><b>%b</b> - Bytes sent, excluding HTTP headers, or '-' if zero</li>
<li><b>%B</b> - Bytes sent, excluding HTTP headers</li>
<li><b>%h</b> - Remote host name (or IP address if
- <code>resolveHosts</code> is false)</li>
+ <code>enableLookups</code> for the connector is false)</li>
<li><b>%H</b> - Request protocol</li>
<li><b>%l</b> - Remote logical username from identd (always returns
'-')</li>
@@ -341,10 +339,8 @@
</attribute>
<attribute name="resolveHosts" required="false">
- <p>Set to <code>true</code> to convert the IP address of the remote
- host into the corresponding host name via a DNS lookup. Set to
- <code>false</code> to skip this lookup, and report the remote IP
- address instead.</p>
+ <p>This attribute is no longer supported. Use the connector
+ attribute <code>enableLookups</code> instead.</p>
</attribute>
<attribute name="suffix" required="false">
Modified: tomcat/trunk/webapps/docs/funcspecs/fs-admin-objects.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/funcspecs/fs-admin-objects.xml?rev=1145387&r1=1145386&r2=1145387&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/funcspecs/fs-admin-objects.xml (original)
+++ tomcat/trunk/webapps/docs/funcspecs/fs-admin-objects.xml Mon Jul 11
22:30:45 2011
@@ -118,7 +118,7 @@ Operations</a> that can be performed whe
<li><code>debug</code> - Debugging detail level. [0]</li>
<li><code>enableLookups</code> - Should we perform DNS lookups on remote
IP addresses when <code>request.getRemoteHost()</code> is called?
- [true]</li>
+ [false]</li>
<li><code>maxProcessors</code> - The maximum number of processor threads
supported by this connector. [20]</li>
<li><code>minProcessors</code> - The minimum number of processor threads
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
