https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #13 from Francis Galiegue <fgalie...@gmail.com> 2011-10-05 14:38:27 UTC --- (In reply to comment #12) > I like this NetMask implementation *much* better. It took me a while to > convince myself that it was correct, but it looks good to me, now. :) > > There are only a few nits of coding style that I would change. I'll post an > updated patch that includes this implementation. > > Did you get a chance to look at my patch? Yes I did. But I'm really not convinced that string matching is a good idea. It may be for IPv4, but for IPv6 it will be a mess. If you remember, I've had the problem that ::1 wouldn't match because the address reported by request.getRemoteHost() (is it the name?) was actually 0:0:0:0:0:0:0:1, which means you have to write it all. Furthermore, it is quite easy to miss a :0 in the mix... I'll continue the work when I get time. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
