Author: kkolinko
Date: Mon Nov 7 11:30:51 2011
New Revision: 1198707
URL: http://svn.apache.org/viewvc?rev=1198707&view=rev
Log:
Followup to r1198696:
- Fix bug in Request#parseParameters():
Forgot to flag the main use case of parsing POST parameters as successful.
- Update comment in FailedRequestFilter.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/catalina/filters/FailedRequestFilter.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1198707&r1=1198706&r2=1198707&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Mon Nov 7
11:30:51 2011
@@ -2897,6 +2897,7 @@ public class Request
parameters.processParameters(formData, 0, formData.length);
}
}
+ success = true;
} finally {
if (!success) {
parameters.setParseFailed(true);
Modified: tomcat/trunk/java/org/apache/catalina/filters/FailedRequestFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/FailedRequestFilter.java?rev=1198707&r1=1198706&r2=1198707&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/filters/FailedRequestFilter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/filters/FailedRequestFilter.java Mon
Nov 7 11:30:51 2011
@@ -38,9 +38,10 @@ import org.apache.juli.logging.LogFactor
*
* <p>
* Note that it has side effect that it triggers parameter parsing and thus
- * consumes the body for POST requests, so use it only with addresses that do
not
- * use <code>request.getInputStream()</code> and
- * <code>request.getReader()</code>.
+ * consumes the body for POST requests. Parameter parsing does check content
+ * type of the request, so there should not be problems with addresses that use
+ * <code>request.getInputStream()</code> and <code>request.getReader()</code>,
+ * if requests parsed by them do not use standard value for content mime-type.
*/
public class FailedRequestFilter extends FilterBase implements CometFilter {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
