2011/11/14  <mt...@apache.org>:
> Author: mturk
> Date: Mon Nov 14 06:19:07 2011
> New Revision: 1201606
>
> URL: http://svn.apache.org/viewvc?rev=1201606&view=rev
> Log:
> Fix code style. No functional change
>
> Modified:
>    tomcat/jk/trunk/native/common/jk_ajp_common.c
>    tomcat/jk/trunk/native/common/jk_pool.c
>    tomcat/jk/trunk/native/common/jk_shm.c
>

In pool.c:

> Modified: tomcat/jk/trunk/native/common/jk_pool.c
> URL: 
> http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_pool.c?rev=1201606&r1=1201605&r2=1201606&view=diff
> ==============================================================================
> --- tomcat/jk/trunk/native/common/jk_pool.c (original)
> +++ tomcat/jk/trunk/native/common/jk_pool.c Mon Nov 14 06:19:07 2011
> @@ -173,13 +173,13 @@ char *jk_pool_strcatv(jk_pool_t *p, ...)
>  #if defined (DEBUG) || defined(_DEBUG)
>  static void jk_dump_pool(jk_pool_t *p, FILE * f)
>  {
> -    fprintf(f, "Dumping for pool [%p]\n",  p);
> -    fprintf(f, "size             [%ld]\n", p->size);
> -    fprintf(f, "pos              [%ld]\n", p->pos);
> -    fprintf(f, "buf              [%p]\n",  p->buf);
> -    fprintf(f, "dyn_size         [%ld]\n", p->dyn_size);
> -    fprintf(f, "dyn_pos          [%ld]\n", p->dyn_pos);
> -    fprintf(f, "dynamic          [%p]\n",  p->dynamic);
> +    fprintf(f, "Dumping for pool [%p]\n", p);
> +    fprintf(f, "size             [%u]\n", (unsigned int)p->size);
> +    fprintf(f, "pos              [%u]\n", (unsigned int)p->pos);
> +    fprintf(f, "buf              [%d]\n", p->buf ? 1 : 0);
> +    fprintf(f, "dyn_size         [%d]\n", (unsigned int)p->dyn_size);
> +    fprintf(f, "dyn_pos          [%d]\n", (unsigned int)p->dyn_pos);

I think it would be s/%d/%u/ in the previous two lines, like already
done above them.

It should not matter, but this commit is all about code style...

> +    fprintf(f, "dynamic          [%d]\n", p->dynamic ? 1 : 0);
>
>     fflush(f);
>  }

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to