Mark, On 3/8/12 4:25 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 8 21:25:31 2012 > New Revision: 1298590 > > URL: http://svn.apache.org/viewvc?rev=1298590&view=rev > Log: > Fix various Checkstyle / Eclipse warnings and failures
This built cleanly for me, and all (expected) tests passed. I saw the buildbot complaint, but I couldn't find any actual errors in the build. The only thing I could make sense of was the javadoc warnings, so I fixed those. > Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=1298590&r1=1298589&r2=1298590&view=diff > ============================================================================== > > @@ -1440,7 +1440,7 @@ public abstract class RealmBase extends > try { > @SuppressWarnings("unchecked") > Class<? extends X509UsernameRetriever> clazz = (Class<? extends > X509UsernameRetriever>)Class.forName(className); > - return (X509UsernameRetriever)clazz.newInstance(); > + return clazz.newInstance(); This was actually intentional: I want the new object to be cast to X509UsernameRetriever *here* so we can catch and re-throw an exception with a nice error message. I didn't check the bytecode, but I assumed that without a cast, no type-check would occur. Working with Java's generics makes my head hurt. Shall I make these same changes in 7.0.x? -chris
signature.asc
Description: OpenPGP digital signature
