2012/5/12 Costin Manolache <cos...@gmail.com>: > On Sat, May 12, 2012 at 8:08 AM, Konstantin Kolinko > <knst.koli...@gmail.com>wrote: > >> Hi! >> >> The SpdyProxyProtocol class (exists in trunk only) uses ajp.Constants >> class: >> >> setSoLinger(Constants.DEFAULT_CONNECTION_LINGER); >> setSoTimeout(Constants.DEFAULT_CONNECTION_TIMEOUT); >> setTcpNoDelay(Constants.DEFAULT_TCP_NO_DELAY); >> >> >> The value of DEFAULT_CONNECTION_TIMEOUT in AJP is -1, >> as opposed to 60000 of HTTP. It seems to be a wrong value to be used here. >> >> Maybe default to 60000 and let one to set "-1" explicitly if it is needed >> (when SPDY is used as a replacement for AJP). >> >> BTW, the fields "cHandler" and "spdyContext" could be private instead >> of package-visible. >> > > +1 - do you want to make the changes, or should I? However the timeout > should be higher than for http - the connection is multiplexed. IMHO the > max connections and timeouts in tomcat are slightly low for current > hardware... >
20 seconds or 60 seconds seems to be realistic. Is there a reason to expect longer delay from valid clients? > Did it work for you ? I didn't hear any feedback - I'm running it on my > home server and seems ok with both nio and java7. > I was just searching for references to DEFAULT_CONNECTION_TIMEOUT to clarify an issue in documentation ([1]) and stumbled upon this oddity. I have not tried to run the class. I think it is for you to fix. I think that spdy package just needs its own copy of the Constants class. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=53203 Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
