2012/5/21 <ol...@apache.org>: > Author: olamy > Date: Mon May 21 08:12:53 2012 > New Revision: 1340918 > > URL: http://svn.apache.org/viewvc?rev=1340918&view=rev > Log: > [MTOMCAT-154] support exec-war war run dependencies with classifiers > Submitted by Peter Lynch. > > Modified: > > tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java > > Modified: > tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java > URL: > http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java?rev=1340918&r1=1340917&r2=1340918&view=diff > ============================================================================== > --- > tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java > (original) > +++ > tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java > Mon May 21 08:12:53 2012 > @@ -322,9 +322,9 @@ public abstract class AbstractExecWarMoj > Dependency dependency = warRunDependency.dependency; > // String groupId, String artifactId, String version, > String scope, String type
The above comment does not match the code anymore. The "scope" is no more used, being replaced by "classifier". I think the comment can be simply removed, as what happens is visible from the code. Best regards, Konstantin Kolinko > Artifact artifact = > - artifactFactory.createArtifact( > dependency.getGroupId(), dependency.getArtifactId(), > - > dependency.getVersion(), dependency.getScope(), > - > dependency.getType() ); > + artifactFactory.createArtifactWithClassifier( > dependency.getGroupId(), dependency.getArtifactId(), > + > dependency.getVersion(), dependency.getType(), > + > dependency.getClassifier() ); > > artifactResolver.resolve( artifact, this.remoteRepos, > this.local ); > File warFile = new File( buildDirectory, > artifact.getFile().getName() ); > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
