2012/5/28 Konstantin Kolinko <knst.koli...@gmail.com>: > 2012/5/28 <ol...@apache.org>: >> Author: olamy >> Date: Mon May 28 15:53:09 2012 >> New Revision: 1343301 >> >> URL: http://svn.apache.org/viewvc?rev=1343301&view=rev >> Log: >> [MTOMCAT-155] allow exec-war war run dependencies that are generated in >> current mvn execution, but not yet installed to maven repo >> Submitted by Peter Lynch. >> >> Modified: >> >> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java >> >>(...) >> @@ -96,6 +94,13 @@ public abstract class AbstractExecWarMoj >> private File buildDirectory; >> >> /** >> + * Path under {@link #buildDirectory} where this mojo may do temporary >> work. >> + * >> + * @parameter default-value="tomcat7-maven-plugin-exec" >> + */ >> + private String pluginWorkDirectory; > > 1. Would it be better to make it a File instead of a String, like > other fields there ? > > 2. It might be useful to allow absolute paths here. > > E.g. if one wants to move it to the system temporary directory, or to > a RAM drive. sounds good idea. I will change that. Thanks for the review! > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
-- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
