I agree using skip must prevent running even if additional webapps have been added. I will change that
2012/6/19 Konstantin Kolinko <knst.koli...@gmail.com>: > 2012/6/18 <ol...@apache.org>: >> Author: olamy >> Date: Mon Jun 18 14:49:43 2012 >> New Revision: 1351368 >> >> URL: http://svn.apache.org/viewvc?rev=1351368&view=rev >> Log: >> [MTOMCAT-60] Multiple-War-Deployment in configuration section. >> >> Added: >> >> tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/Webapp.java >> (with props) >> Modified: >> >> tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java >> > > >> --- >> tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java >> (original) >> +++ >> tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java >> Mon Jun 18 14:49:43 2012 >>(..) >> @@ -378,7 +417,8 @@ public abstract class AbstractRunMojo >> public void execute() >> throws MojoExecutionException, MojoFailureException >> { >> - if ( skip && !addContextWarDependencies ) >> + >> + if ( skip && !addContextWarDependencies && >> getAdditionalWebapps().isEmpty() ) >> { >> getLog().info( "skip execution" ); >> return; > > The above "if(skip)" clause in tomcat6/AbstractRunMojo.java > > Do you ignore "skip execution" flag unless two other conditions are met? > > Do you need to replace s/ && / || / there ? > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
