On 13.07.2012 18:45, Konstantin Kolinko wrote:
2012/7/13 Rainer Jung <rainer.j...@kippdata.de>:
1) Japanese HTTP Status Codes
=============================
The file
java/org/apache/tomcat/util/http/res/LocalStrings_ja.properties
is functionally identical to
java/org/apache/tomcat/util/http/res/LocalStrings.properties
(apart from changes introduced by me a few minutes ago).
I don't see any use in having all the english messages duplicated in the
Japanese file. I'd remove all lines except for a header that makes clear
that we don't want to introduce non-TEXT messages.
Any objections?
2) Backport r1361263
====================
I plan to backport
http://svn.apache.org/viewvc?rev=1361263&view=rev
to TC 7.
Note that there is a change for 302 from "Moved Temporarily" to "Found". The
standards compliant text "Found" is also used by the Apache Web Server.
I do not really like how many "{0}" are used in those messages in the
valves' resource file. There was some discussion of that in
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071#c9
Thanks for the hint, I didn't follow that discussion.
As far as I can see, those properties are only used in ErrorReportValve.
There they are only put into the "report", which is only output in an
HTML document directly below the "message" that would have been put into
{0}.
In addition the same "message" is again being output as an h1 heading
shortly before.
So I see no reason at all to keep the "message" inside the "report". I
suggest to drop it (drop the parameter from all those properties and
rephrase them were it is grammatically needed).
Regarding the Japanese file: I think it is possible to remove the
messages, but I think that you should not remove the file itself.
Agreed.
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
