Author: markt
Date: Sun Jul 22 22:17:59 2012
New Revision: 1364448
URL: http://svn.apache.org/viewvc?rev=1364448&view=rev
Log:
Make utility method static and save a few object instances
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/trunk/java/org/apache/catalina/util/MD5Encoder.java
tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Sun Jul 22 22:17:59 2012
@@ -58,7 +58,10 @@ public class DigestAuthenticator extends
/**
* The MD5 helper object for this class.
+ *
+ * @deprecated Unused - will be removed in Tomcat 8.0.x
*/
+ @Deprecated
protected static final MD5Encoder md5Encoder = new MD5Encoder();
@@ -366,7 +369,7 @@ public class DigestAuthenticator extends
ipTimeKey.getBytes(B2CConverter.ISO_8859_1));
}
- return currentTime + ":" + md5Encoder.encode(buffer);
+ return currentTime + ":" + MD5Encoder.encode(buffer);
}
@@ -621,7 +624,7 @@ public class DigestAuthenticator extends
buffer = md5Helper.digest(
serverIpTimeKey.getBytes(B2CConverter.ISO_8859_1));
}
- String md5ServerIpTimeKey = md5Encoder.encode(buffer);
+ String md5ServerIpTimeKey = MD5Encoder.encode(buffer);
if (!md5ServerIpTimeKey.equals(md5clientIpTimeKey)) {
return false;
}
@@ -685,7 +688,7 @@ public class DigestAuthenticator extends
synchronized (md5Helper) {
buffer =
md5Helper.digest(a2.getBytes(B2CConverter.ISO_8859_1));
}
- String md5a2 = md5Encoder.encode(buffer);
+ String md5a2 = MD5Encoder.encode(buffer);
return realm.authenticate(userName, response, nonce, nc, cnonce,
qop, realmName, md5a2);
Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Sun Jul 22
22:17:59 2012
@@ -109,7 +109,10 @@ public abstract class RealmBase extends
/**
* The MD5 helper object for this class.
+ *
+ * @deprecated Unused - will be removed in Tomcat 8.0.x
*/
+ @Deprecated
protected static final MD5Encoder md5Encoder = new MD5Encoder();
@@ -405,7 +408,7 @@ public abstract class RealmBase extends
String serverDigest = null;
// Bugzilla 32137
synchronized(md5Helper) {
- serverDigest = md5Encoder.encode(md5Helper.digest(valueBytes));
+ serverDigest = MD5Encoder.encode(md5Helper.digest(valueBytes));
}
if (log.isDebugEnabled()) {
@@ -1206,7 +1209,7 @@ public abstract class RealmBase extends
digest = md5Helper.digest(valueBytes);
}
- return md5Encoder.encode(digest);
+ return MD5Encoder.encode(digest);
}
Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Sun Jul
22 22:17:59 2012
@@ -212,7 +212,10 @@ public class WebdavServlet
/**
* The MD5 helper object for this class.
+ *
+ * @deprecated Unused - will be removed in Tomcat 8.0.x
*/
+ @Deprecated
protected static final MD5Encoder md5Encoder = new MD5Encoder();
@@ -1145,7 +1148,7 @@ public class WebdavServlet
+ lock.depth + "-" + lock.owner + "-" + lock.tokens + "-"
+ lock.expiresAt + "-" + System.currentTimeMillis() + "-"
+ secret;
- String lockToken = md5Encoder.encode(md5Helper.digest(
+ String lockToken = MD5Encoder.encode(md5Helper.digest(
lockTokenStr.getBytes(B2CConverter.ISO_8859_1)));
if ( (exists) && (object instanceof DirContext) &&
Modified: tomcat/trunk/java/org/apache/catalina/util/MD5Encoder.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/MD5Encoder.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/util/MD5Encoder.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/MD5Encoder.java Sun Jul 22
22:17:59 2012
@@ -33,6 +33,14 @@ package org.apache.catalina.util;
public final class MD5Encoder {
+ /**
+ * @deprecated Will be made private in Tomcat 8.0.x
+ */
+ @Deprecated
+ public MD5Encoder() {
+ // NOOP
+ }
+
// ----------------------------------------------------- Instance Variables
@@ -50,7 +58,7 @@ public final class MD5Encoder {
* @param binaryData Array containing the digest
* @return Encoded MD5, or null if encoding failed
*/
- public String encode( byte[] binaryData ) {
+ public static String encode( byte[] binaryData ) {
if (binaryData.length != 16)
return null;
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
---
tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
Sun Jul 22 22:17:59 2012
@@ -364,9 +364,8 @@ public class TestDigestAuthenticator ext
private static String digest(String input) throws NoSuchAlgorithmException
{
// This is slow but should be OK as this is only a test
MessageDigest md5 = MessageDigest.getInstance("MD5");
- MD5Encoder encoder = new MD5Encoder();
md5.update(input.getBytes());
- return encoder.encode(md5.digest());
+ return MD5Encoder.encode(md5.digest());
}
}
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
---
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java
Sun Jul 22 22:17:59 2012
@@ -472,10 +472,9 @@ public class TestSSOnonLoginAndDigestAut
private static String digest(String input) throws NoSuchAlgorithmException
{
// This is slow but should be OK as this is only a test
MessageDigest md5 = MessageDigest.getInstance("MD5");
- MD5Encoder encoder = new MD5Encoder();
md5.update(input.getBytes());
- return encoder.encode(md5.digest());
+ return MD5Encoder.encode(md5.digest());
}
/*
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java?rev=1364448&r1=1364447&r2=1364448&view=diff
==============================================================================
---
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
Sun Jul 22 22:17:59 2012
@@ -180,16 +180,15 @@ public class TesterDigestAuthenticatorPe
String a2 = METHOD + ":" + CONTEXT_PATH + URI;
MessageDigest digester = MessageDigest.getInstance("MD5");
- MD5Encoder encoder = new MD5Encoder();
- String md5a1 = encoder.encode(digester.digest(a1.getBytes()));
- String md5a2 = encoder.encode(digester.digest(a2.getBytes()));
+ String md5a1 = MD5Encoder.encode(digester.digest(a1.getBytes()));
+ String md5a2 = MD5Encoder.encode(digester.digest(a2.getBytes()));
String response = md5a1 + ":" + nonce + ":" + ncString + ":" +
cnonce + ":" + QOP + ":" + md5a2;
String md5response =
- encoder.encode(digester.digest(response.getBytes()));
+ MD5Encoder.encode(digester.digest(response.getBytes()));
StringBuilder auth = new StringBuilder();
auth.append("Digest username=\"");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
