On 09/09/2012 15:24, Konstantin Kolinko wrote: > 2012/9/9 <ma...@apache.org>: >> Author: markt >> Date: Sat Sep 8 21:11:46 2012 >> New Revision: 1382367 >> >> URL: http://svn.apache.org/viewvc?rev=1382367&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52777 >> Implement optional automatic removal of old applications where parallel >> deployment has been used. > > Regarding checkUndeploy(): > 1. I think it should check whether the current app version is up and running.
Fair point. Done. > 2. I suspect that if the old version is stopped, it should not be > auto-undeployed as well. > > I do not have a good explanation for this though. In this case I suspect that users wouldn't enable the auto-undeploy. > 3. There should be a check for isServiced(). Also done. > 4. Some synchronization is needed. > E.g. checkResources() is a synchronized method. I think chekUndeploy > should be synchronized as well. Agreed. Thanks for the review. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
