https://issues.apache.org/bugzilla/show_bug.cgi?id=53895
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
There are multiple concerns with this proposal.
1. Patches should be provided in diff -u format and not include formatting
changes. It took time to get the proposed new class into a form where a true
diff (no formatting changes) was available to review.
2. A few hundred milliseconds difference over 10 million look-ups is not very
much. I'd be prepared to make the change in this case as the new code is no
more complex than the old.
3. Testing locally I only see a few 10s of ms difference in the provided test
case. That makes applying the patch a lot harder to justify.
4. Experimenting with different scopes (rather than pageContext) shows the new
version is slower, not faster, for some. Any future proposal (and I am not sure
it is worth pursuing) needs to include a testcase that examines all scopes
rather than one that appears to show the most favourable results.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
