On 22.11.2012 12:43, Konstantin Kolinko wrote: > 2012/11/20 Rainer Jung <rainer.j...@kippdata.de>: >> On 08.11.2012 23:25, Konstantin Kolinko wrote: >>> 2012/11/8 Rainer Jung <rainer.j...@kippdata.de>:
>> So I suggest to support comments only on the official tomcat.a.o and use >> full page URLs as the prototype does. >> > > If we need a single official URL, I would prefer to use > https://tomcat.apache.org/ (with HTTPS). As in "better be safe". > > Other than that I am OK with enabling the feature on tomcat.a.o only. I think for http and https there might be some code in comments. I'll check whether we can support http and https in parallel. >> Updated patch available at >> http://people.apache.org/~rjung/patches/tc-trunk-comments-v2.patch > > +1. Good. > > There is stray "+LICENSE" line before "<section name="Privacy > Policy">" in comments.xml. Right, I added the word as a reminder when I wrote the file and forgot to remove it. > I think you'll want to apply additional > menu items (those additions in project.xml files) regardless of this > patch. Mr Eagle eye :) Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
