That is the wrong fix. The missing "response = reader.readline();" need to be 
inserted. The test should be making sure there are two messages echoed back.

I'd fix this myself but I am on a mobile device and editing is a little tricky. 
I'll fix it later today if no-one else beats me to it.

Mark

kkoli...@apache.org wrote:

>Author: kkolinko
>Date: Sun Nov 25 10:51:14 2012
>New Revision: 1413324
>
>URL: http://svn.apache.org/viewvc?rev=1413324&view=rev
>Log:
>Remove duplicate line.
>(It compares a String with a String. The result does not depend on
>whether it is called once or twice).
>
>Modified:
>    tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
>
>Modified:
>tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java?rev=1413324&r1=1413323&r2=1413324&view=diff
>==============================================================================
>--- tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
>(original)
>+++ tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
>Sun Nov 25 10:51:14 2012
>@@ -93,7 +93,6 @@ public class TestUpgrade extends TomcatB
>         // Note: BufferedReader.readLine() strips new lines
>        //       ServletInputStream.readLine() does not strip new lines
>         Assert.assertEquals(MESSAGE, response);
>-        Assert.assertEquals(MESSAGE, response);
>     }
> 
> 
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to