2012/11/25  <ma...@apache.org>:
> Author: markt
> Date: Sat Nov 24 23:12:49 2012
> New Revision: 1413281
>
> URL: http://svn.apache.org/viewvc?rev=1413281&view=rev
> Log:
> WebSocket 1.0 implementation part 1 of many.
> Implement the the bootstrap code for Endpoints defined both using 
> POJOS+annotations and programmatically.
> At this stage the ServerContainer just dumps relevant info to stdout.
> Add initial an implementation of the Echo example for each of the approaches.
>
> Added:
>     tomcat/trunk/java/org/apache/websocket/
>     tomcat/trunk/java/org/apache/websocket/ClientContainerImpl.java   (with 
> props)
>     tomcat/trunk/java/org/apache/websocket/ServerContainerImpl.java   (with 
> props)
>     tomcat/trunk/java/org/apache/websocket/Util.java   (with props)
>     tomcat/trunk/java/org/apache/websocket/WsSci.java   (with props)
>     tomcat/trunk/java/org/apache/websocket/WsServlet.java   (with props)
>     tomcat/trunk/res/META-INF/default/
>     tomcat/trunk/res/META-INF/websocket-impl.jar/
>     tomcat/trunk/res/META-INF/websocket-impl.jar/services/
>     
> tomcat/trunk/res/META-INF/websocket-impl.jar/services/javax.servlet.ServletContainerInitializer
>    (with props)
>     tomcat/trunk/test/org/apache/websocket/
>     tomcat/trunk/test/org/apache/websocket/TestUtil.java   (with props)
>     
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAnnotation.java
>    (with props)
>     
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoEndpoint.java
>    (with props)
>     
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/WsConfigListener.java
>    (with props)
> Modified:
>     tomcat/trunk/build.xml
>     tomcat/trunk/conf/catalina.properties
>     tomcat/trunk/java/javax/websocket/ContainerProvider.java
>     tomcat/trunk/java/javax/websocket/WebSocketEndpoint.java
>     tomcat/trunk/webapps/examples/WEB-INF/web.xml
>

This commit introduces package "org.apache.websocket" and files
"websocket-impl.jar", "websocket-impl-src.jar


1. I think it would be better to have
"org.apache.tomcat.websocket.*",  instead of "org.apache.websocket.*".

The o.a.tomcat namespace belongs to our PMC. The chance of a conflict
with other Apache projects will be smaller.


2. I think it would be better to have
"tomcat-websocket-impl.jar" or simply "tomcat-websocket.jar" instead
of "websocket-impl.jar"

In Maven you will name it "tomcat-<foo>.jar" anyway.
There will be less conflicts from including such a name into "jarsToSkip" list.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to