Author: markt
Date: Wed Jan 23 10:09:03 2013
New Revision: 1437317
URL: http://svn.apache.org/viewvc?rev=1437317&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54448
Correctly handle @Resource annotations on primitives.
Includes test case.
Patch provided by Violeta Georgieva.
Added:
tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java
tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java
tomcat/trunk/java/org/apache/catalina/util/Introspection.java
tomcat/trunk/test/org/apache/catalina/startup/TestContextConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java?rev=1437317&r1=1437316&r2=1437317&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java (original)
+++ tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java Wed Jan
23 10:09:03 2013
@@ -1177,7 +1177,7 @@ public class NamingResources extends Lif
// No match - ignore this injection target
continue;
}
- targetType = convertPrimitiveType(targetType);
+ targetType = Introspection.convertPrimitiveType(targetType);
if (typeClass == null) {
// Need to find a common type amongst the injection targets
@@ -1230,26 +1230,4 @@ public class NamingResources extends Lif
}
return null;
}
-
- private Class<?> convertPrimitiveType(Class<?> clazz) {
- if (clazz.equals(char.class)) {
- return Character.class;
- } else if (clazz.equals(int.class)) {
- return Integer.class;
- } else if (clazz.equals(boolean.class)) {
- return Boolean.class;
- } else if (clazz.equals(double.class)) {
- return Double.class;
- } else if (clazz.equals(byte.class)) {
- return Byte.class;
- } else if (clazz.equals(short.class)) {
- return Short.class;
- } else if (clazz.equals(long.class)) {
- return Long.class;
- } else if (clazz.equals(float.class)) {
- return Float.class;
- } else {
- return clazz;
- }
- }
}
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java?rev=1437317&r1=1437316&r2=1437317&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java Wed Jan
23 10:09:03 2013
@@ -265,7 +265,7 @@ public class WebAnnotationSet {
Resource annotation = field.getAnnotation(Resource.class);
String defaultName =
classClass.getName() + SEPARATOR + field.getName();
- String defaultType = field.getType().getCanonicalName();
+ Class<?> defaultType = field.getType();
addResource(context, annotation, defaultName, defaultType);
}
}
@@ -290,8 +290,8 @@ public class WebAnnotationSet {
String defaultName = classClass.getName() + SEPARATOR +
Introspection.getPropertyName(method);
- String defaultType =
- (method.getParameterTypes()[0]).getCanonicalName();
+ Class<?> defaultType =
+ (method.getParameterTypes()[0]);
addResource(context, annotation, defaultName, defaultType);
}
}
@@ -309,7 +309,7 @@ public class WebAnnotationSet {
}
protected static void addResource(Context context, Resource annotation,
- String defaultName, String defaultType) {
+ String defaultName, Class<?> defaultType) {
String name = getName(annotation, defaultName);
String type = getType(annotation, defaultType);
@@ -412,14 +412,14 @@ public class WebAnnotationSet {
}
- private static String getType(Resource annotation, String defaultType) {
- String type = annotation.type().getCanonicalName();
- if (type == null || type.equals("java.lang.Object")) {
+ private static String getType(Resource annotation, Class<?> defaultType) {
+ Class<?> type = annotation.type();
+ if (type == null || type.equals(Object.class)) {
if (defaultType != null) {
type = defaultType;
}
}
- return type;
+ return Introspection.convertPrimitiveType(type).getCanonicalName();
}
Modified: tomcat/trunk/java/org/apache/catalina/util/Introspection.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/Introspection.java?rev=1437317&r1=1437316&r2=1437317&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/util/Introspection.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/Introspection.java Wed Jan 23
10:09:03 2013
@@ -153,4 +153,34 @@ public class Introspection {
}
return clazz;
}
+
+ /**
+ * Converts the primitive type to its corresponding wrapper.
+ *
+ * @param clazz
+ * Class that will be evaluated
+ * @return if the parameter is a primitive type returns its wrapper;
+ * otherwise returns the same class
+ */
+ public static Class<?> convertPrimitiveType(Class<?> clazz) {
+ if (clazz.equals(char.class)) {
+ return Character.class;
+ } else if (clazz.equals(int.class)) {
+ return Integer.class;
+ } else if (clazz.equals(boolean.class)) {
+ return Boolean.class;
+ } else if (clazz.equals(double.class)) {
+ return Double.class;
+ } else if (clazz.equals(byte.class)) {
+ return Byte.class;
+ } else if (clazz.equals(short.class)) {
+ return Short.class;
+ } else if (clazz.equals(long.class)) {
+ return Long.class;
+ } else if (clazz.equals(float.class)) {
+ return Float.class;
+ } else {
+ return clazz;
+ }
+ }
}
Modified: tomcat/trunk/test/org/apache/catalina/startup/TestContextConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestContextConfig.java?rev=1437317&r1=1437316&r2=1437317&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/startup/TestContextConfig.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TestContextConfig.java Wed
Jan 23 10:09:03 2013
@@ -126,6 +126,25 @@ public class TestContextConfig extends T
assertPageContains("/test/testServlet", "postConstruct1()");
}
+ @Test
+ public void testBug54448() throws Exception {
+ Tomcat tomcat = getTomcatInstance();
+
+ File appDir = new File("test/webapp-3.0-fragments");
+ Context context = tomcat.addWebapp(null, "/test",
+ appDir.getAbsolutePath());
+
+ Tomcat.addServlet(context, "TestServlet",
+ "org.apache.catalina.startup.TesterServletWithAnnotations");
+ context.addServletMapping("/testServlet", "TestServlet");
+
+ tomcat.enableNaming();
+
+ tomcat.start();
+
+ assertPageContains("/test/testServlet", "envEntry: 1");
+ }
+
private static class CustomDefaultServletSCI
implements ServletContainerInitializer {
Added:
tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java?rev=1437317&view=auto
==============================================================================
---
tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java
(added)
+++
tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java
Wed Jan 23 10:09:03 2013
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.startup;
+
+import java.io.IOException;
+
+import javax.annotation.Resource;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public class TesterServletWithAnnotations extends HttpServlet {
+
+ private static final long serialVersionUID = 1L;
+
+ @Resource(mappedName = "1")
+ private int envEntry;
+
+ @Override
+ protected void doGet(HttpServletRequest req, HttpServletResponse resp)
+ throws ServletException, IOException {
+ resp.setContentType("text/plain");
+ resp.getWriter().print("envEntry: " + envEntry);
+ }
+}
Propchange:
tomcat/trunk/test/org/apache/catalina/startup/TesterServletWithAnnotations.java
------------------------------------------------------------------------------
svn:eol-style = native
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
