https://issues.apache.org/bugzilla/show_bug.cgi?id=54468

--- Comment #8 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to comment #7)
> I think you are confused?  ctx->context_id is not a pointer but a byte array.

Er...

> See the declaration;
> 
>     unsigned char   context_id[SHA_DIGEST_LENGTH];
>
> [...]
>
> sizeof(ctx->context_id) is in fact 20.
> 
> sizeof(&ctx->context_id) would in fact be 8 as you observe.

Aah, I forgot that sizeof (specifically) can resolve that as a statically-sized
array instead of returning the size of the pointer type. context_id is most
definitely a pointer to "unsigned char" no matter what you say. sizeof is an
aberration in this respect (and documented as such in Harrison & Steele).

I still think you should use either SHA_DIGEST_LENGTH or even define yet
another constant like TCN_DIGEST_LENGTH to be an alias of SHA_DIGEST_LENGTH.
Using sizeof is misleading at best.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to