On 25.01.2013 17:01, jean-frederic clere wrote:
> Version 1.1.26 is bug fixing release.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Native 1.1.26 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
+1 to release
Detailed results ("-" indicates things which we could improve). Though
the list is long, it is again shorter than when I checked last time
(1.1.24). Overall I'm still +1 for stable, because I didn't find
regressions. But there is room for improvement.
+ Tested with Java 1.6.0_37 (but configured against Java 1.5.0_22),
APR 1.4.6 and OpenSSL 1.0.1c
+ Platforms Solaris 8+10 Sparc, SLES 10, 32 and 64 Bits,
SLES 11 64 Bits, RHEL 5+6 64 Bits
+ MD5 OK
+ signatures OK
+ key in KEYS file
- File 'bin/tcnative-1-src.pdb' missing in the binaries zips
- name of ocsp binary changed from
...ocsp-win32... to ...win32-ocsp...
(changed back to how it was before 1.1.24).
+ gz and zip for sources consistent
- Except for different permissions: zip seems to also contain group
write permissions. Not a real problem, but it's a bit strange
that perms differ between the archive (no regression).
+ source dist consistent with svn tag
- config-guess and config.sub should get an update this year
('2011-05-11' resp. '2011-03-23' instead of recent '2012-12-30'
resp. '2013-01-23'). They are copied from the APR source tree
when running buildconf.
+ recreated release with jnirelease script, results are
consistent with source dist, except for minor expected diffs in
CHANGELOG.txt, build-outputs.mk and generated docs
(whitespace and attribute ordering)
+ make succeeds and builds lib (no warnings)
- most unit tests contained in TC 7 headrun successful with
APR connector and this version of tcnative
Except:
- TestMaxConnections: failed on several platforms, but also for
non-apr connectors. Not reproducible
- TestStandardWrapper: Crash on Solaris 8 during shutdown
Stack see end of mail.
- ant part of build (no regressions, cited from 1.1.24 tests):
- No mentioning of running "ant download" before tests. Without
it test compilation fails.
- "ant test" fails in line 85 of SocketServerTestSuite.java, because
on my system the checking for precisely 2 milliseconds won't work.
The call returns after 11 millis not after 2
- "ant run-echo": will fail, because by default uses privileged
port 23. Maybe switch to 8023? Users should not run tests as root.
- "ant run-ssl-server": Could't we include a test certificates in the
test folder? What should the test produce, if run successfully?
- "ant run-local-server": Creates a unix socket "\\.\PIPE\test" in the
examples directory, then waits. How is the test expected to work?
And the file name doesn't seem to be appropriate for Unix.
- run-echo, run-ssl-server and run-local-server: I couldn't figure
out, what those were actually supposed to show (what is a positive
result vs. a negative one).
Last time sebb responded to the announcement mail:
--------- 8>< ---------------
Please include a brief synopsis (1 or 2 sentences) of the purpose of
the TLP/Product in all announcements sent outside the TLP mailing
lists.
The developers and users will (presumably) know what the product is
about, but others are unlikely to know.
S.
P.S. Just about every other TLP includes this information, including HTTD...
--------- 8>< ---------------
You might want to add such type of info to the announcement for 1.1.26.
Stack of crash during unit test on Solaris 8 (non-reproducible):
C [libapr-1.so.0+0x14d54] apr_allocator_destroy+0x10
C [libapr-1.so.0+0x15a7c] apr_pool_terminate+0x4c
j org.apache.tomcat.jni.Library.terminate()V+0
j org.apache.tomcat.jni.Library.terminate()V+0
v ~StubRoutines::call_stub
V [libjvm.so+0xe8ff8] void
JavaCalls::call_helper(JavaValue*,methodHandle*,JavaCallArguments*,Thread*)+0x218
V [libjvm.so+0x506c94]
oopDesc*Reflection::invoke(instanceKlassHandle,methodHandle,Handle,bool,objArrayHandle,BasicType,objArrayHandle,bool,Thread*)+0x13a8
V [libjvm.so+0x178048]
oopDesc*Reflection::invoke_method(oopDesc*,Handle,objArrayHandle,Thread*)+0x260
V [libjvm.so+0x177a9c] JVM_InvokeMethod+0x350
C [libjava.so+0x10d6c]
Java_sun_reflect_NativeMethodAccessorImpl_invoke0+0x18
j
sun.reflect.NativeMethodAccessorImpl.invoke0(Ljava/lang/reflect/Method;Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+0
j
sun.reflect.NativeMethodAccessorImpl.invoke0(Ljava/lang/reflect/Method;Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+0
j
sun.reflect.NativeMethodAccessorImpl.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+87
J
sun.reflect.DelegatingMethodAccessorImpl.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;
J
java.lang.reflect.Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;
j org.apache.catalina.core.AprLifecycleListener.terminateAPR()V+23
j
org.apache.catalina.core.AprLifecycleListener.lifecycleEvent(Lorg/apache/catalina/LifecycleEvent;)V+151
J
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Ljava/lang/String;Ljava/lang/Object;)V
J
org.apache.catalina.util.LifecycleBase.setStateInternal(Lorg/apache/catalina/LifecycleState;Ljava/lang/Object;Z)V
j org.apache.catalina.util.LifecycleBase.destroy()V+286
j org.apache.catalina.startup.Tomcat.destroy()V+9
j org.apache.catalina.startup.TomcatBaseTest.tearDown()V+57
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
