https://issues.apache.org/bugzilla/show_bug.cgi?id=54552
--- Comment #10 from Nick Williams <nicho...@nicholaswilliams.net> --- Created attachment 29943 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29943&action=edit Revised diff with extra whitespace removed I hadn't noticed notifySessionListenersOnReplication. I have revised the DeltaManager to take that into consideration before notifying HttpSessionIdListeners. I see what my problem was with validation, now. My execute.validate=true was being overridden by an execute.validate=false later in the file. Should have looked for that. I'm kind of surprised that y'all don't allow blank lines between code groups to contain tab-spaces to be in line with the rest of the code. It seems such a trivial thing. Your website says "Apache Tomcat has very loosely defined coding conventions" (and doesn't mention anything about blank lines/whites paces), but I would not call that "loose" :-P. But, whatever the rules, my diff complies now, as requested. By the way, webapps\docs\jasper-howto.xml that was just checked in failed the validate test. After fixing all of my code I had to disable validation to get it to completely compile. :-) I've attached the updated diff with the extra whitespace removed and notifySessionListenersOnReplication taken into consideration. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
