Author: markt
Date: Sat Feb 16 21:31:51 2013
New Revision: 1446952
URL: http://svn.apache.org/r1446952
Log:
UCDetector
- use final
- reduce visibility
- remove unused code
Modified:
tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java Sat Feb
16 21:31:51 2013
@@ -81,7 +81,7 @@ public class JspContextWrapper extends P
private ELContext elContext = null;
- private PageContext rootJspCtxt;
+ private final PageContext rootJspCtxt;
public JspContextWrapper(JspContext jspContext,
ArrayList<String> nestedVars, ArrayList<String> atBeginVars,
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java Sat Feb 16
21:31:51 2013
@@ -174,7 +174,7 @@ public class JspFactoryImpl extends JspF
}
}
- protected static final class PageContextPool {
+ private static final class PageContextPool {
private final PageContext[] pool;
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java Sat Feb
16 21:31:51 2013
@@ -59,12 +59,12 @@ public class JspRuntimeLibrary {
protected static class PrivilegedIntrospectHelper
implements PrivilegedExceptionAction<Void> {
- private Object bean;
- private String prop;
- private String value;
- private ServletRequest request;
- private String param;
- private boolean ignoreMethodNF;
+ private final Object bean;
+ private final String prop;
+ private final String value;
+ private final ServletRequest request;
+ private final String param;
+ private final boolean ignoreMethodNF;
PrivilegedIntrospectHelper(Object bean, String prop,
String value, ServletRequest request,
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java Sat Feb 16
21:31:51 2013
@@ -56,16 +56,6 @@ public class JspWriterImpl extends JspWr
}
/**
- * Create a buffered character-output stream that uses a default-sized
- * output buffer.
- *
- * @param response A Servlet Response
- */
- public JspWriterImpl(ServletResponse response) {
- this(response, Constants.DEFAULT_BUFFER_SIZE, true);
- }
-
- /**
* Create a new buffered character-output stream that uses an output
* buffer of the given size.
*
@@ -340,7 +330,8 @@ public class JspWriterImpl extends JspWr
}
- static final String lineSeparator = System.getProperty("line.separator");
+ private static final String lineSeparator =
+ System.getProperty("line.separator");
/**
* Write a line separator. The line separator string is defined by the
Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Sat Feb 16
21:31:51 2013
@@ -83,7 +83,7 @@ public class PageContextImpl extends Pag
private String errorPageURL;
// page-scope attributes
- private transient HashMap<String, Object> attributes;
+ private final transient HashMap<String, Object> attributes;
// per-request state
private transient ServletRequest request;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
