On 01/03/2013 22:44, Remy Maucherat wrote: > About endOfInput, I wouldn't use it. The only place where it is somewhat > useful is the URI conversion, which can check the underflow flag and > throw an exception. Especially if you also want to have "perfect" body > decoding, you'll have to use that flag and throw your exception since it > won't be able to use endOfInput. I don't bother with either personally, > but it's the reason for the existence of the flag.
If we want to use replacement (as Konstantin has convinced me on) then it will be easier to have the decoder do it which means using endOfInput (or effectively re-implementing it which seems pointless to me) > The main purpose of the new B2C and C2B code is to have better handling > of non blocking (not required in Servlet 3.1, in the end; at least for > now), and that's about it. Since they also look better, save memory and > are symmetrical, I thought it would be a good idea to add them. I didn't > expect to cause so much trouble, ;) :) No trouble at all. I much prefer the new ones. The changes may have prompted us to look at how this code is used more carefully but I suspect 7.0.x will have far more issues than trunk does. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
