On Mar 9, 2013, at 3:15 PM, Nick Williams wrote: > I'm implementing the Part#getSubmittedFileName method introduced in > SERVLET_SPEC-57 [1]. > > o.a.c.core.ApplicationPart already has a getFilename method that accomplishes > this that is not part of the interface but IS public. This method is used > only in o.a.c.connector.Request (once), but that's easy to change. The > concern is that renaming this method might break applications that depend on > the old method name (despite the fact that using Tomcat proprietary code > makes their application non-portable). Is it a problem to rename this method > in a new major version, or should Part have both methods, with one calling > the other? > > [1] http://java.net/jira/browse/SERVLET_SPEC-57
Based on what others had done in the past, I deprecated getFilename and wrapped it around getSubmittedFileName. Patch has been submitted via bug #54658. If I need to remove getFilename instead of deprecating it, I can resubmit my patch if asked. Nick --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
