https://issues.apache.org/bugzilla/show_bug.cgi?id=54709
--- Comment #2 from Nick Williams <nicho...@nicholaswilliams.net> ---
Note one potential problem:
if (port == -1) {
if ("ws".equalsIgnoreCase(scheme)) {
sa = new InetSocketAddress(host, 80);
} else {
// TODO HTTPS support
// sa = new InetSocketAddress(host, 443);
throw new DeploymentException("TODO: HTTPS");
}
} else {
sa = new InetSocketAddress(host, port);
}
Now, I understand that SSL support is not complete yet, but as-written this
won't allow customization of the port when connecting via SSL (wss). It is
imperative that this be allowed (consider port 8443 as an example). Suggestion:
if ("ws".equalsIgnoreCase(scheme)) {
if (port == -1) {
port = 80;
}
sa = new InetSocketAddress(host, port);
} else {
if (port == -1) {
port = 443;
}
// TODO HTTPS support
// sa = new InetSocketAddress(host, port);
throw new DeploymentException("TODO: HTTPS");
}
Of course, you may be planning on doing that anyway when you complete SSL
support.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
