2013/6/12 <ma...@apache.org>: > Author: markt > Date: Wed Jun 12 18:31:30 2013 > New Revision: 1492331 > > URL: http://svn.apache.org/r1492331 > Log: > With clarification from the EG for Servlet 3.1 section 4.4 finally makes > sense. Implement the necessary restriction and add a test case. > > Added: > > tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/ApplicationListener.java > - copied unchanged from r1492307, > tomcat/trunk/java/org/apache/catalina/deploy/ApplicationListener.java > tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TesterTldListener.java > - copied unchanged from r1492307, > tomcat/trunk/test/org/apache/catalina/core/TesterTldListener.java > tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/listener.tld > - copied unchanged from r1492307, > tomcat/trunk/test/webapp-3.0/WEB-INF/listener.tld > Modified: > tomcat/tc7.0.x/trunk/ (props changed) > tomcat/tc7.0.x/trunk/java/javax/servlet/ServletContext.java > tomcat/tc7.0.x/trunk/java/org/apache/catalina/Context.java > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties > tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java > tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/WebXml.java > tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/FailedContext.java > tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java > > tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java > > tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java > > tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestNamingContextListener.java > > tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContext.java > tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TesterContext.java > tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TestListener.java >
1. Do not forget to update the changelog. 2. Looking at update of javadoc in j.s.ServletContext java, Why is there restriction for getEffectiveMajorVersion(), getEffectiveMinorVersion() methods? They are not used for programmatic configuration of servlets/filters/listeners and they are not mentioned in Chapter 4.4, so I think there should not be such restriction on calling them. 3. You changed a method in o.a.c.Context. We usually add methods there, but do not change the existing ones. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
