On Jul 31, 2013, at 7:31 AM, Mark Thomas <ma...@apache.org> wrote: > On 29/07/2013 20:48, Mark Thomas wrote: >> On 29/07/2013 01:01, jboy...@apache.org wrote: >>> Author: jboynes >>> Date: Sun Jul 28 23:01:23 2013 >>> New Revision: 1507870 >>> >>> URL: http://svn.apache.org/r1507870 >>> Log: >>> Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 >>> >>> Decouple service loading for ServletContainerInitializers from >>> ContextConfig and >>> ensure services defined by the parent ClassLoader are discovered. >>> >>> Added: >>> tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java >>> (with props) >>> >>> tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java >>> (with props) >> >> This new test doesn't assert anything. It is also triggering an unused >> code warning in Eclipse. > > ping
I deleted the test as ineffectual: http://svn.apache.org/r1508261 The existing test suite is testing integration for the loader but I still think it needs more unit tests. I've been sick last couple days so haven't had a chance to add them. I don't use Eclipse so a pointer to the problem it's reporting would be helpful. Thanks Jeremy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
