-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22/11/2013 16:10, Jeremy Boynes wrote: > On Nov 22, 2013, at 1:28 AM, Mark Thomas <ma...@apache.org> wrote: > > Still catching up on the changes but this jumped out: >> >>> Looks like JasperInitializer now reads to read an attribute >>> not an init-param. In trunk, I'd been trying to decouple Jasper >>> from Catalina so having the latter set a jasper-specific >>> attribute reverts that - in TC7 this is controlled for each >>> JspServlet using a "validating" init-param (i.e. it does not >>> inherit from the Context). >> >> There are multiple aspects to this. >> >> Jasper needs to be usable in other containers so it can't depend >> on Catalina. Both attributes and init-params allow this. >> >> There are some things - like XML validation - that apply to both >> Catalina and Jasper and users shouldn't have to configure this >> in multiple places. attributes vs. init-params are really just >> the mechanism used to pass config from Catalina to Jasper in this >> case. I think it is easier to do this with attributes than >> init-params. > > The issue with magic attributes though is that that container > needs to set them, whereas init-params can be set in a descriptor > supplied with the application. I think attributes are easier as > well but think there's benefit in the other container case of > having Jasper's configuration be standalone not need container > support. > > Ideally this configuration would be exposed to an SCI in way > defined by the spec (e.g. a javax. attribute or method on > ServletContext).
You've convinced me. I'll move them from attributes to init-params. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSj4XnAAoJEBDAHFovYFnnmz4QANs83fGZJZ3xfei1w9tyPrAq CCodms1rROEUMpXIX27PHiMm/5910EIMvC3Jdl2NzM7acyZTJJbhU+dk8vC/W9/L H51aMYYiB9BGIcUi9qIptG2bwI8tc/Rtc9toB64yPeGOXtU5wI+ssixENe/rPwBV hDSozIxqs6J4Kl59O9fg4T6U/KGzmuiUiLmVDFVEvEQDXw8ew51NqA5DjJ8bFNkV q0A9oWAsCDULvper1QdQGL3by1SPRJNnU/+5FON7i8pA1a1oCTqO9ZoLb5gkIwTr CsT7QsH2hNkjOl2oiUdELJJkOHZLKKbSQr4rKiFkv1lC2TWrVibC18tm7D3wU5I7 vDvGC8I83xocnJkpkIHlu2tzyIT1WM5eO1Lp5PdovreiQLDrSbwMzkVEresepRRd OrTmh8UM9W8bLH2zHGXsz75q9rjGBmOHVUqqhwE3G8Lb9DK8XHWK+gNOvaahtcsb jkm2AchJywyN2C/CaZyamrICxLUbSlGyde0BVLh5WoljRhZdwPKuW2ceRaJSn9Mo 0QmZhALJb0/C8tTmoxKmzBhH15OQ+9NMFwV1PVmloJwo9bhp5myvF/XtClGhVoab 8++pXIzGkZ69OKhdjXyGINFupTFn4AN8DVzHv1gcgaWFuwW9TKX0INTrseSgUpSq HkYbwnJn37QvRPmAdGJg =uwdw -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
