On 17.12.2013 11:01, Rainer Jung wrote: > A) TC 7 > ======= > > 3) org.apache.tomcat.websocket.TestWsSubprotocols > ------------------------------------------------- > > 1 x bio, 1 x nio > > > Failure: > > Testcase: testWsSubprotocols took 4.005 sec > Caused an ERROR > null > java.lang.NullPointerException > at > org.apache.tomcat.websocket.TestWsSubprotocols.testWsSubprotocols(TestWsSubprotocols.java:89) > > > Logs: Nothing interesting > > > Next steps: I'll add some debug logs locally to TestWsSubprotocols and > see how far I get.
Added logging shows: - Most often the sequence is SubProtocolsEndpoint.processOpen(), then the subprotocol assertion check which comes after wsContainer.connectToServer() and wsSession.isOpen() and finally another SubProtocolsEndpoint.processOpen(). In this case the test succeeds. - Rarely the assertion check comes after both SubProtocolsEndpoint.processOpen() calls, then the test also succeeds - Rarely the assertion check comes before the two calls to SubProtocolsEndpoint.processOpen(), then the test fails with NPE, because SubProtocolsEndpoint.subprotocols wasn't assigned yet (that happens in SubProtocolsEndpoint.processOpen()). Would it be OK to add a short sleep before the assertion or does that changed order of execution in fact indicate a server side problem instead of a test impl problem? Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
