-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 18/01/2014 04:34, Jeremy Boynes wrote: > On Jan 15, 2014, at 2:38 AM, Mark Thomas <ma...@apache.org> wrote: > >> Does any one have anything else to add to >> http://wiki.apache.org/tomcat/Cookies ? It feels like we should >> be looking to make some decisions on where to go with this. >> >> My $0.02 to start this discussion is that we should adopt the all >> of the proposed changes with the following notes: - C1 rather >> C1a > > I have uploaded a patch for the Cxx changes here: > http://people.apache.org/~jboynes/patches/cookie.patch It’s also > linked off the wiki page.
Generally +1. The build.xml change does not belong in the patch. Formatting changes can be committed now, removing them from the patch and making it easier to read. I had to stop and think when looking at TOKEN. It is right but it isn't 100% clear what is happening. I'd suggest using TOKEN.set(32,127) and a comment on the separators list that \t is already excluded but is included in the list for completeness. Use String.length() == 0 or String.isEmpty() consistently. I'm a little concerned about anonymous cookies. Is the browser support consistent? Is anyone using them? Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS2lx6AAoJEBDAHFovYFnnyMIP/0zuzu1kInx2hX/N2BYyJxor EMe2wV6NKnKXfmmD+pO/vBmDaHPq+ADc7vpt+UV/CBWPaAE+WhiJXht0RAXNABqM COItpwOninbRPEzqBsvdh/R+K5hMSiGZ1KvK7OgOhErBsFZSk4XSUyBLxZVxlu9W I1RiwOiIJ+RkMvI2kULrTz5mUUdQhfXKJKO4lDLkl5Uk53q4hxq7rtSKiHPKw+mn mu5Vwn94l7RJ2ATeiGNpmelLkz4cePd1drzVIoCQOCkUmhZYOu17ZOY/wVuJ7XTW zaz+Au8aWdK2NLbTPZaZQMjnmoSXUzI6Zq4kq8zHL+zcQyIe9NWwf3Bb/coXUsER /st0DU2k7xr4B58o0hyyFLy9OnyP3ZRYQQlmMLEHJoth6xBozqkW0OIWoAMobOyt lGn5W+LymtpwqGX8b6YWOQWRY1/WGRfDJI1O6KD6QkLYEG+HAAXoMF6GBqQDjVXe neEIHCZQrhWK/dnP5mK2X36ORwyO3FFUPrtWvPWYmiCqgCplPlnOrUhClfFEk3rG tvbZdIKsgsnOSab3FBAbF5p/FT7XcqY1DDErnWSPy3nq6p9J/jOsy0OYTfvtX0V2 QGo//OS5g7TpCGNvmzTUgQjiDUzozKlPQwgl5fOr0wgkOtu7d0OFQgPjqgd+uLT6 GP7Wjw965KQ7gkfdn7qP =3UUW -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
