On 11/02/2014 14:38, Konstantin Kolinko wrote: > 2014-02-11 17:32 GMT+04:00 Mark Thomas <ma...@apache.org>: >> On 11/02/2014 11:42, Violeta Georgieva wrote: >>> The proposed Apache Tomcat 7.0.51 release is now available for voting. >>> >>> It can be obtained from: >>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.51/ >>> The Maven staging repo is: >>> https://repository.apache.org/content/repositories/orgapachetomcat-1006/ >>> The svn tag is: >>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_51/ >>> >>> The proposed 7.0.51 release is: >>> [X] Broken - do not release >>> [ ] Stable - go ahead and release as 7.0.51 Stable >> >> I'm seeing TCK failures for the JSP TCK. >> >> The improved XML validation is highlighting an issue in the merged >> web.xml that gets passed to Jasper. It always declares a 3.0 (for Tomcat >> 7, 3.1 for Tomcat 8.0) schema but the actual version may be any from >> 2.2. to 3.0. >> >> The toXml() method of WebXml looks like it needs some work. I'm >> currently taking a look. > > > If you are really going to implement a valid descriptor for an old > version of the spec, > the root element may be not all that is there.
Agreed. > I see you also took care of metadata-complete=\"true\". OK. > > The following also comes to mind: > <filter-mapping>, <servlet-mapping> in 2.4 do not support multiple > <url-pattern> elements. > (Each pattern needs its own <**-mapping> element). With validation enabled, a 2.4 source with multiple url-pattern elements will be rejected when it is first parsed so the code won't reach the generated of the "merged" web.xml in that case. I think this is true generally. The "merged" output for anything pre 3.0 is going to be effectively a copy of the original web.xml so any errors should be picked up on the initial validation. > There might be some other options (inherited from the default > conf/web.xml) that do not make sense in previous versions. The defaults have been handled (else the new tests would not pass). I don't think there are any edge cases I missed but there are enough moving parts that there might be. I'm happy fixing those edge cases as and when they arise. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
