2014-03-04 21:51 GMT+01:00 Mark Thomas <ma...@apache.org>: > >> Can you wait until we split 8.0.x from trunk or did you want to get this > >> into 8.0.x? > >> > > > > Depends, if you want to branch soon or not. It would have to be > > experimental for a while anyway, but it will likely bring something > useful. > > I would like to branch soon. On the other hand if we hold this back > until 9.0.x then it will be a lot longer before folks can really use it. >
It's very early in 8.0, so there would be plenty of time to backport if it is not included before branching. I thought you backported everything anyway. Basically, I can commit it as soon as there's general agreement on it, it's very easy in the meantime to keep rebasing on trunk. I'll try to work on improving the testsuite status as much as possible [I see some websockets tests failing - not a big surprise -, although a lot of it is working], and also see how I can remove that isReady from the AbstractServletInputStream. > > > I think the spec says there should be a /0.0 version number, and I like > the > > Coyote name, but you can change it. > > I'll try to remember to take a look at it. Maybe just change it to match > the Tomcat major/minor version numbers. > Ok. > Thanks for the clarifications. I'm +1 with the following caveats: > - no @author tags > - exclude the change that makes NIO2 the default > - document that the NIO2 connector is currently experimental > > - They came from the NIO1 classes I used as the basis for the new classes, should I remove them anyway ? - I changed that already. - Yes, I copied from the current NIO documentation, but "experimental" is not mentioned anywhere, which is obviously a mistake. I'll add a log during the endpoint start, so that it can't be missed, it's the best way (nobody reads the docs ...). Rémy
