Author: kkolinko
Date: Fri Mar 21 08:35:17 2014
New Revision: 1579896
URL: http://svn.apache.org/r1579896
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579896&r1=1579895&r2=1579896&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Mar 21 08:35:17 2014
@@ -33,7 +33,7 @@ PATCHES PROPOSED TO BACKPORT:
Prevent user supplied XSLTs used by the DefaultServlet from defining external
entities.
http://people.apache.org/~markt/patches/2014-03-17-globalXsltFile-tc6-v1.patch
- +1: markt
+ +1: markt, kkolinko
-1: schultz: The idea of the patch is fine: I'm actually +1.
I have some small nits:
1. DocumentBuilderFactory is not thread-safe, and shouldn't
@@ -41,6 +41,40 @@ PATCHES PROPOSED TO BACKPORT:
when closing File streams. We should at least log a warning.
It looks like there is an opportinity to use StringBuilder
instead of StringBuffer, there, too, if you want.
+ kkolinko:
+ Re 1.:
+ The newDocumentBuilder() method is thread safe.
+
+ See JSR 206 (Final Release = JAXP 1.3)
+ https://jcp.org/en/jsr/detail?id=206
+ Ch.3 -> Thread Safety
+ [quote]
+ Implementations of the SAXParser, DocumentBuilder, Transformer,
Validator and Validat
+ orHandler abstract classes are not expected to be thread safe by
this specification. (...)
+
+ Configuration of a SAXParserFactory, DocumentBuilderFactory
TransformerFactory or
+ SchemaFactory is also not expected to be thread safe. (...)
+
+ It is expected that the newSAXParser method of a SAXParserFactory
implementation, the newDocument
+ Builder method of a DocumentBuilderFactory and the newTransformer
method of a Transformer
+ Factory will be thread safe without side effects. (...)
+
+ Note that Schema is thread safe.
+ [/quote]
+
+ Re 2.:
+ Those are input streams that are read, not written. Nothing
+ should really happen when those are closed.
+
+ Re StringBuilder:
+ I think it is not of much concern. But if there is any interest,
+ I am proposing a patch below. It is a 4 years old one.
+ -1:
+
+* Use StringBuilder in DefaultServlet
+ Apply only DefaultServlet.java part of the following patch:
+
https://people.apache.org/~kkolinko/patches/StringBuilder/2009-11-02_StringBuilder_o_a_c_servlets.patch
+ +1: kkolinko
-1:
* Fix possible overflow when parsing long values from a byte array.
@@ -48,7 +82,8 @@ PATCHES PROPOSED TO BACKPORT:
+1: markt, kkolinko, schultz
-1:
-* Add Java 8 support to Jasper's default configuration
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56283
+ Add Java 8 support to Jasper's default configuration
http://people.apache.org/~markt/patches/2014-03-19-Jasper-Java8-tc6-v1.patch
+1: markt
+0: kkolinko:
@@ -65,8 +100,10 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
Don't escape values for dynamic tag attributes
http://people.apache.org/~markt/patches/2014-03-19-bug56265-tc6-v1.patch
- +1: markt
+ +1: markt, kkolinko
-1:
+ kkolinko: Beware that changelog part of this patch merges into a wrong
+ place. This change belongs to Jasper, not Catalina.
* Update tc-native to 1.1.29
http://people.apache.org/~markt/patches/2014-03-19-tc-native-tc6-v1.patch
@@ -76,7 +113,7 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275
Fix memory leak if a Filter throws an exception during its destroy() method
http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
- +1: markt, schultz
+ +1: markt, schultz, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
