https://issues.apache.org/bugzilla/show_bug.cgi?id=56382
Danila Galimov <b...@mail.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #3 from Danila Galimov <b...@mail.ru> ---
(In reply to Konstantin Kolinko from comment #2)
> Comment on attachment 31506 [details]
> Proposed patch
>
> In reply to attachment 31506 [details]
>
> > if( log.isInfoEnabled() )
> > + startTime = System.currentTimeMillis();
> > log.info(sm.getString("hostConfig.deployDir",
> > dir.getAbsolutePath()));
>
> 1. The above change breaks the code, because of missing '{' after an 'if'
> above.
Fixed.
> > System.currentTimeMillis() - startTime
>
> 2. Boxing and unboxing have to be explicit, per our coding rules.
Fixed.
> 3. This covers only 'deployDirectory(..)' method. What about the others?
Done for deployDirectory, deployWAR and deployDescriptor methods.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
