Author: markt Date: Thu Jun 5 10:01:18 2014 New Revision: 1600579 URL: http://svn.apache.org/r1600579 Log: Update the error count regardless of how the error flag was set Ensure that an request can only contribute to the error count once
Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=1600579&r1=1600578&r2=1600579&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Thu Jun 5 10:01:18 2014 @@ -386,7 +386,13 @@ public class Response * Set the error flag. */ public void setError() { - error = true; + if (!error) { + error = true; + Wrapper wrapper = getRequest().getWrapper(); + if (wrapper != null) { + wrapper.incrementErrorCount(); + } + } } @@ -1193,11 +1199,6 @@ public class Response return; } - Wrapper wrapper = getRequest().getWrapper(); - if (wrapper != null) { - wrapper.incrementErrorCount(); - } - setError(); coyoteResponse.setStatus(status); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org