Author: kkolinko
Date: Tue Jun 17 23:03:40 2014
New Revision: 1603311
URL: http://svn.apache.org/r1603311
Log:
Review of r1597602:
1) Be satisfied by the first result from ServiceLoader and break the loop.
2) Throw LogConfigurationException, which is a subtype of RuntimeException.
Modified:
tomcat/trunk/java/org/apache/juli/logging/LogFactory.java
Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/LogFactory.java?rev=1603311&r1=1603310&r2=1603311&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/juli/logging/LogFactory.java (original)
+++ tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Tue Jun 17
23:03:40 2014
@@ -79,6 +79,7 @@ public class LogFactory {
Class<? extends Log> c=log.getClass();
try {
m=c.getConstructor(String.class);
+ break;
}
catch (NoSuchMethodException | SecurityException e) {
throw new Error(e);
@@ -118,7 +119,7 @@ public class LogFactory {
return discoveredLogConstructor.newInstance(name);
} catch (InstantiationException | IllegalAccessException |
IllegalArgumentException |
InvocationTargetException e) {
- throw new RuntimeException(e);
+ throw new LogConfigurationException(e);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
