[ 
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097945#comment-14097945
 ] 

ASF GitHub Bot commented on MTOMCAT-234:
----------------------------------------

GitHub user kalgon opened a pull request:

    https://github.com/apache/tomcat-maven-plugin/pull/7

    MTOMCAT-234 Classloading issues

    this fixes the `java.lang.ClassFormatError` but there is another problem: 
it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies 
instead of the webapp ones. The result is that no `web-fragment.xml` or 
`ServletContainerInitializer` works anymore (and I suspect there should be 
other consequences as well). I did not have enough time to investigate but I 
noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it 
wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't 
know the internals of Tomcat very well. I'll try to make some time next week to 
dig a bit deeper.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat-maven-plugin/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496
Author: kalgon <kal...@hotmail.com>
Date:   2014-08-14T10:47:12Z

    MTOMCAT-234 Classloading issues

----


> Tomcat8 Maven Plugin
> --------------------
>
>                 Key: MTOMCAT-234
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-234
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Dependency upgrade
>    Affects Versions: 2.0, 2.1, 2.2
>         Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
>            Reporter: Petr Novak
>            Assignee: Olivier Lamy (*$^¨%`£)
>            Priority: Blocker
>             Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin. 
> I tried the recommendations in 
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline 
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
>  ... 20 more
> by: java.lang.NoSuchMethodError: 
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>  ... 20 more
>  The method setDefaultRealm is deprecated in Tomcat7 and was removed in 
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to