Author: kkolinko
Date: Thu Sep 18 10:57:51 2014
New Revision: 1625938
URL: http://svn.apache.org/r1625938
Log:
Comments
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1625938&r1=1625937&r2=1625938&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 18 10:57:51 2014
@@ -42,11 +42,28 @@ PATCHES PROPOSED TO BACKPORT:
* Assert that MappingData object is empty before performing mapping work.
It is backport of r1604663
+
+ Motivation: Remove dead branches. Protect Mapper from operating on
+ non-recycled MappingData. Using non-recycled MappingData might result in
+ mapping request onto a different target, like an issue that prevented us
+ from releasing 8.0.4 and fixed by r1580080/r1580083. I do not know such
+ bugs in Tomcat 6, but I want the code to be more safe.
+ Just a single (mappingData.host != null) check is enough to discern
+ recycled vs. non-recycled data. Checks for other MappingData fields are
+ removed by this patch, simplifying the code.
+
+ A patch generated with "svn diff -x --ignore-space-change" for easier
+ overview of the change is
+
https://people.apache.org/~kkolinko/patches/2014-06-23_tc6_Mapper_diff-x-b.patch
+
https://people.apache.org/~kkolinko/patches/2014-06-23_tc6_Mapper.patch
+1: kkolinko
-1:
* Fix generics warnings in Mapper.
+
+ Motivation: Resolve IDE warnings to make it easier to spot more serious
+ errors when working on this class.
It is just some local variables. No change in functionality or APIs.
https://people.apache.org/~kkolinko/patches/2014-06-23_tc6_Mapper_generics.patch
+1: kkolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
