On Wed, Oct 8, 2014 at 1:02 PM, Mark Thomas <ma...@apache.org> wrote:

> On 08/10/2014 11:41, Martin Grigorov wrote:
>
> It really helps if you are going to comment on a small part of a large
> commit if you trim the irrelevant parts of the original in your reply.
>

I'll try to remember for the next time.
In my mail client it is a matter of a single click to see what is before or
after such inline comment, so I thought it is easy for others too.


>
> >> Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java?rev=1630065&r1=1630064&r2=1630065&view=diff
> >>
> >>
> ==============================================================================
> >> --- tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java
> (original)
> >> +++ tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java Wed Oct
> >> 8 10:38:33 2014
> >> @@ -61,6 +61,8 @@ public class Constants {
> >>              WS_PROTOCOL_HEADER_NAME.toLowerCase(Locale.ENGLISH);
> >>      public static final String WS_EXTENSIONS_HEADER_NAME =
> >>              "Sec-WebSocket-Extensions";
> >> +    public static final Object WS_EXTENSIONS_HEADER_NAME_LOWER =
> >>
> >
> > Why the type is Object ?
>
> Because I got the IDE to generate the code and didn't notice it created
> a String. I'll get that fixed.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Reply via email to