https://issues.apache.org/bugzilla/show_bug.cgi?id=57132

--- Comment #1 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Created attachment 32139
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32139&action=edit
2014-10-22_tc8_57132_testcases.patch

Updated testcases for TestImportHandler to test that duplicate calls still
report an error.

A comment in ImportHandler class shows my first idea on fixing this. If I
remove first duplicate from the cache it fixes duplicate check in
resolveClass() but breaks duplicate check in importClass().

I think that if I move duplicate removal from the cache into resolveClass()
method itself, it will be fixed. But maybe there is a more clean solution.


BTW, there is no control that the class name argument in resolveClass() is
actually a simple name without a package. JavaEE javadoc says that it should be
simple name, but there is no control of that fact. JavaEE does not say whether
it is ELException or IAE to be thrown if such a check were added. I think it is
an ELException. [1]

[1] http://docs.oracle.com/javaee/7/api/javax/el/ImportHandler.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to