Author: markt Date: Fri Jan 9 18:42:52 2015 New Revision: 1650627 URL: http://svn.apache.org/r1650627 Log: Add a warning based on what appears to have been the fix for an APR crash after the recent refactoring.
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java?rev=1650627&r1=1650626&r2=1650627&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Fri Jan 9 18:42:52 2015 @@ -187,6 +187,20 @@ public abstract class SocketWrapperBase< return hasMoreDataToFlush() || bufferedWrites.size() > 0; } + /** + * Checks to see if there is any writes pending and if there is calls + * {@link #registerWriteInterest()} to trigger a callback once the pending + * write has completed. + * <p> + * Note: Once this method has returned <code>false</code> it <b>MUST NOT</b> + * be called again until the pending write has completed and the + * callback has been fired. + * TODO: Modify {@link #registerWriteInterest()} so the above + * restriction is enforced there rather than relying on the caller. + * + * @return <code>true</code> if no writes are pending and data can be + * written otherwise <code>false</code> + */ public boolean isReadyForWrite() { boolean result = !hasDataToWrite(); if (!result) { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org