https://bz.apache.org/bugzilla/show_bug.cgi?id=58042

            Bug ID: 58042
           Summary: SlowQueryReport failed query logging
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: kwill...@gmail.com

The SlowQueryReport JDBC interceptor catches Exceptions, by default logs them,
and rethrows them. There is an option with the latest version not to write the
message to the log, but it still sends it to JMX. It is very common in
enterprise frameworks (such as Spring JDBC) to call a method, catch any
exception thrown and handle the exception. All of this is normal activity. It
should not be logged, it should not be sent to JMX. So first I would argue that
SlowQueryReport SHOULD NOT log failed SQL statements at all. It is not
documented as such, and it is a pain in the ??? that it does. :-) Second, it
you will not remove the functionality, please understand that JMX and logging
should "log" the same actions. So the setting should effect both. But again, if
you want to make it hard to configure, by all means create yet another setting
to control sending failed SQL to JMX. Finally, if you will not remove the
functionality, please change the default to NOT log failed SQL. Minimal
configuration is best. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to