Wanted to bring it up for discussion before we announce it to the world. Didn't notice it until reviewing the notes.
Good concept, but the term "alias" isn't accurate and overlaps awkwardly with the existing "provider" concept. Also seems like there's some sort of multiple inheritance thing going on it it, which is a little strange. Looked for some details in the tests, but didn't find anything illuminating. There is a test, but doesn't show how the properties would be merged to create one canonical resource definition. The ServiceProviderInheritanceTest, which does identical inheritance with the 'provider' attribute, has pretty extensible tests for guaranteeing the way we handle the properties is fixed and stable. Not sure we need two nearly identical inheritance concepts. Maybe best to boil them down to one. -David On Apr 14, 2013, at 1:45 PM, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Hi guys > > shouldn't we remove the version = trunk? it doesn't mean anything and > doesn't help to identify when it was fixed. > > wdyt? > > *Romain Manni-Bucau* > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>* > *Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/> > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > *Github: https://github.com/rmannibucau* > > > > 2013/4/14 David Blevins (JIRA) <j...@apache.org> > >> >> [ >> https://issues.apache.org/jira/browse/TOMEE-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >> >> David Blevins updated TOMEE-662: >> -------------------------------- >> >> Fix Version/s: (trunk/tomee) >> >>> Support aliases on resources >>> ---------------------------- >>> >>> Key: TOMEE-662 >>> URL: https://issues.apache.org/jira/browse/TOMEE-662 >>> Project: TomEE >>> Issue Type: New Feature >>> Reporter: Romain Manni-Bucau >>> Assignee: Romain Manni-Bucau >>> Fix For: 1.5.2, (trunk/tomee) >>> >>> >>> <Resource type="DataSource" id="foo" aliases="bar,dummy"> >>> ... >>> </Resource> >>> the idea is to reuse the same instance (avoid to create 2 datasources >> when not needed for instance) >>> it shoudl work with properties format too: >>> foo = new://Resource?type=DataSource&aliases=foo >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators >> For more information on JIRA, see: http://www.atlassian.com/software/jira >>
